[PATCH] D58187: Teach DTU to recalculate DT/PDT automatically when EntryBB is changed

Chijun Sima via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 13 09:15:20 PST 2019

NutshellySima added a comment.

In D58187#1396464 <https://reviews.llvm.org/D58187#1396464>, @brzycki wrote:

> This is much cleaner, I like this very much. Originally adding the method `recalculate()` was a compromise. With this change do we even need the public `recalculate()`method? Does it ever make sense to make a new entry BB that has zero successors?

recalculate() can be deprecated. But there are still edge cases, for example, when we only insert a new block to be the entry block or move a block up to be the entry block, it is still needed to call `flush()` to detect this change. (But I don't see usage like the above scenario I mentioned currently.)

  rG LLVM Github Monorepo



More information about the llvm-commits mailing list