[PATCH] D58103: [llvm-readobj] Only allow 4-byte pr_data and refactor GNU_PROPERTY_X86_FEATURE_1_AND processing a bit
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Feb 12 00:59:58 PST 2019
MaskRay added a comment.
In D58103#1394386 <https://reviews.llvm.org/D58103#1394386>, @grimar wrote:
> Looks correct, FTR ABI link is https://github.com/hjl-tools/x86-psABI/wiki/x86-64-psABI-draft.pdf.
> Regarding the refactoring, in my opinion, the original code was simpler. I would leave it as is.
> (at least refactoring change could be in a separate patch, if you want to do it)
For `GNU_PROPERTY_X86_FEATURE_1_AND`, there are only 2 bits. When people start implementing
`GNU_PROPERTY_X86_ISA_1_USED` `GNU_PROPERTY_X86_ISA_2_USED` `GNU_PROPERTY_X86_COMPAT_ISA_1_USED`, this style will become better :)
CHANGES SINCE LAST ACTION
More information about the llvm-commits