[PATCH] D58103: [llvm-readobj] Only allow 4-byte pr_data and refactor GNU_PROPERTY_X86_FEATURE_1_AND processing a bit
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Feb 12 00:55:11 PST 2019
grimar added a comment.
Looks correct, FTR ABI link is https://github.com/hjl-tools/x86-psABI/wiki/x86-64-psABI-draft.pdf.
Regarding the refactoring, in my opinion, the original code was simpler. I would leave it as is.
(at least refactoring change could be in a separate patch, if you want to do it)
CHANGES SINCE LAST ACTION
More information about the llvm-commits