[PATCH] D57962: [DebugInfo] PR40628: Don't salvage load operations

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 11 09:22:17 PST 2019


aprantl added a comment.

I think you convinced me. It doesn't make me happy that we have to drop this, but that's not your fault :-)



================
Comment at: lib/Transforms/Utils/Local.cpp:1704
       return nullptr;
     }
   }
----------------
Could you please add a comment here explaining why we don't salvage loads, so no-one comes back later with a great idea and adds it back in?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57962/new/

https://reviews.llvm.org/D57962





More information about the llvm-commits mailing list