[PATCH] D57962: [DebugInfo] PR40628: Don't salvage load operations

[Adrian Prantl via Phabricator via llvm-commits]

aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.

I think you convinced me. It doesn't make me happy that we have to drop this, but that's not your fault :-)



================
Comment at: test/DebugInfo/Generic/pr40628.ll:13
+
+; CHECK-NOT: DW_OP_deref
+
----------------
Please add some kind of positive CHECK, too, otherwise this test would pass even if someone symlinked opt to /bin/true :-)


================
Comment at: test/DebugInfo/Generic/pr40628.ll:19
+define dso_local i32 @foo(i32*, i32, i32) !dbg !7 {
+  %4 = load i32, i32* %0, align 4, !dbg !18, !tbaa !19
+  call void @llvm.dbg.value(metadata i32 %4, metadata !16, metadata !DIExpression()), !dbg !23
----------------
Is the tbaa data needed?


================
Comment at: test/DebugInfo/Generic/pr40628.ll:20
+  %4 = load i32, i32* %0, align 4, !dbg !18, !tbaa !19
+  call void @llvm.dbg.value(metadata i32 %4, metadata !16, metadata !DIExpression()), !dbg !23
+  %5 = load i32, i32* %0, align 4, !dbg !24, !tbaa !19
----------------
Could you get by with fewer distinct DILocations? i.e., would just attaching !23  everywhere work, too?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57962/new/

https://reviews.llvm.org/D57962