[PATCH] D57947: GlobalISel: Add G_FCANONICALIZE instruction

Fri Feb 8 12:26:02 PST 2019

aditya_nandakumar accepted this revision.
aditya_nandakumar added a comment.
This revision is now accepted and ready to land.

LGTM. Minor comment that's not really concerning - but if you feel like it please fix that as well.

================
Comment at: test/CodeGen/AMDGPU/GlobalISel/legalize-fcanonicalize.mir:61
+    ; SI: [[TRUNC:%[0-9]+]]:_(s16) = G_TRUNC [[COPY]](s32)
+    ; SI: [[FPEXT:%[0-9]+]]:_(s32) = G_FPEXT [[TRUNC]](s16)
+    ; SI: [[FCANONICALIZE:%[0-9]+]]:_(s32) = G_FCANONICALIZE [[FPEXT]]
----------------
It's a bit weird mixing integer truncates with FPExts, but as this is just a test, it probably can't hurt.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57947/new/

https://reviews.llvm.org/D57947