[PATCH] D57947: GlobalISel: Add G_FCANONICALIZE instruction

Fri Feb 8 12:08:47 PST 2019

arsenm marked an inline comment as done.
arsenm added inline comments.

================
Comment at: test/CodeGen/AMDGPU/GlobalISel/legalize-fcanonicalize.mir:20
+    %0:_(s32) = COPY $vgpr0
+    %1:_(s32) = G_FCANONICALIZE %0
+...
----------------
aditya_nandakumar wrote:
> IIUC, there needs to be a side effecting user of %1 otherwise it'll be DCEd. Is a
> ```
> $vgpr0 = COPY %1
> ```
> missing here?
Thanks, there were a bunch of these I had been copying between tests. I thought I had found all of them already

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57947/new/

https://reviews.llvm.org/D57947