[PATCH] D57947: GlobalISel: Add G_FCANONICALIZE instruction

Fri Feb 8 11:50:24 PST 2019

aditya_nandakumar added inline comments.

================
Comment at: test/CodeGen/AMDGPU/GlobalISel/legalize-fcanonicalize.mir:20
+    %0:_(s32) = COPY $vgpr0
+    %1:_(s32) = G_FCANONICALIZE %0
+...
----------------
IIUC, there needs to be a side effecting user of %1 otherwise it'll be DCEd. Is a
```
$vgpr0 = COPY %1
```
missing here?

================
Comment at: test/CodeGen/AMDGPU/GlobalISel/legalize-fcanonicalize.mir:35
+    %0:_(s64) = COPY $vgpr0_vgpr1
+    %1:_(s64) = G_FCANONICALIZE %0
+...
----------------
Ditto.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57947/new/

https://reviews.llvm.org/D57947