[PATCH] D40147: [MIPS] Handle cross-mode (regular <-> microMIPS) jumps
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Feb 8 01:32:34 PST 2019
grimar accepted this revision.
grimar added a comment.
This revision is now accepted and ready to land.
LGTM, but please wait for Rui's opinion too.
================
Comment at: lld/ELF/Arch/Mips.cpp:523
+ // FIXME (simon): Support valid branch relocations.
+ break;
+ default:
----------------
grimar wrote:
> Is it ok to ignore these, or should it trigger an error instead maybe?
Oh, please ignore this comment. So the error below will be triggered.
Repository:
rLLD LLVM Linker
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D40147/new/
https://reviews.llvm.org/D40147
More information about the llvm-commits
mailing list