[PATCH] D40147: [MIPS] Handle cross-mode (regular <-> microMIPS) jumps

[George Rimar via Phabricator via llvm-commits]

grimar added a comment.

I am not a specialist in MIPS, but the code itself in this diff looks much better to me.



================
Comment at: lld/ELF/Arch/Mips.cpp:471
+  }
+}
+
----------------
I would rewrite this in a shorter way:

```
return Type == R_MIPS_26 || Type == R_MIPS_PC26_S2 ... ;
```


================
Comment at: lld/ELF/Arch/Mips.cpp:483
+  }
+}
+
----------------
The same.


================
Comment at: lld/ELF/Arch/Mips.cpp:523
+    // FIXME (simon): Support valid branch relocations.
+    break;
+  default:
----------------
Is it ok to ignore these, or should it trigger an error instead maybe?


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D40147/new/

https://reviews.llvm.org/D40147