[PATCH] D57632: [WebAssembly] Fix imported function symbol names that differ from their import names in the .o format
Sam Clegg via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Feb 7 12:18:28 PST 2019
sbc100 accepted this revision.
sbc100 added a comment.
This revision is now accepted and ready to land.
lgtm % comment about tests
Remember to update the tool-convensions/Linking.md with this new symbol flag
================
Comment at: tools/lld/test/wasm/import-names.ll:93
+; CHECK: - Index: 2
+; CHECK: Name: _start
+; CHECK: ...
----------------
I'd be tempted to only include `IMPORT` and `CUSTOM` sections, and to use `CHECK-NEXT`.
We only care about the name of function 0 too.
e.g.
```
; CHECK: - Type: CUSTOM
; CHECK-NEXT: Name: name
; CHECK-NEXT: FunctionNames:
; CHECK-NEXT: - Index: 0
; CHECK-NEXT: Name: f0
```
Same for the MC test
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57632/new/
https://reviews.llvm.org/D57632
More information about the llvm-commits
mailing list