[PATCH] D57632: [WebAssembly] Fix imported function symbol names that differ from their import names in the .o format

Thu Feb 7 11:31:29 PST 2019

sunfish added a comment.

In D57632#1384200 <https://reviews.llvm.org/D57632#1384200>, @sbc100 wrote:

> Looking good.
>
> Can we can a test in the MC/WebAssembly and lld/test/wasm?

Done.

> Any not do the same for data symbols?

Data symbols don't have a corresponding import, and already include a symbol string unconditionally.

> We probably want to fail in lld if two different object import the same symbol with the different import name or import module, but that was already on my radar and I'm OK to do that as a followup.

Yes, that sounds good to do.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57632/new/

https://reviews.llvm.org/D57632