[PATCH] D57533: lit: support long paths on Windows

Zachary Turner via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 6 07:28:41 PST 2019


The entire point of these builtins is to handle cases that standard tools
either don’t exist or fall short on. So to me, making the built in rm
handle long paths makes perfect sense. Telling someone we require an rm
that handles long paths just makes it harder on the user, because now they
have to worry about which rm to get and how to get it.

And if we find out that find doesn’t work with long paths, then we just
reimplement find as a built in too, which seems to be WAI
On Tue, Feb 5, 2019 at 5:39 PM Rui Ueyama via Phabricator <
reviews at reviews.llvm.org> wrote:

> ruiu added a comment.
>
> I didn't say it's easy at the moment but I don't think it is not that
> wrong to expect that the situation will be better over time. So as always
> it's a trade-off. Where is the location we currently generate long
> pathnames?
>
>
> Repository:
>   rL LLVM
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D57533/new/
>
> https://reviews.llvm.org/D57533
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190206/cc8faa78/attachment.html>


More information about the llvm-commits mailing list