[PATCH] D57759: [PowerPC] Code Cleanup Remove u1imm

Stefan Pintilie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 5 15:57:52 PST 2019


stefanp abandoned this revision.
stefanp added a comment.

Hi Hal, 
I'm actually not going to do this in the end.... I'm just going to abandon this patch.
I realized that we did actually need this type too.

The `u1imm` type is actually an i32 which is later restricted to be either a 0 or a 1. On the other hand the `i1imm` type is an i1. This is an important difference.

The issue is that some of the instructions that use this type have builtins. For example: `vshasigmaw`. The builtin requires that the single bit be passed in as a parameter and that means we need to use an i32. Anyway I'm going to leave the type in.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57759/new/

https://reviews.llvm.org/D57759





More information about the llvm-commits mailing list