[PATCH] D57759: [PowerPC] Code Cleanup Remove u1imm

Hal Finkel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 5 14:56:33 PST 2019


hfinkel added a comment.

In D57759#1385950 <https://reviews.llvm.org/D57759#1385950>, @stefanp wrote:

> Hi Hal,
>  Thank you for the review.
>  I've looked around but the only place we use u1imm is where we only have 1 bit to use in the instruction anyway so we have no way to represent -1 anyway.


Okay. This is just a question of parsing and text formatting. A 1-bit signed number is -1 or 0, and an unsigned 1-bit number is 1 or 0.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57759/new/

https://reviews.llvm.org/D57759





More information about the llvm-commits mailing list