[PATCH] D57769: [PDB] Remove dots and canonicalize slashes when using /PDBSOURCEPATH
Nico Weber via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Feb 5 12:25:57 PST 2019
thakis added a comment.
Ah, I see.
It feels a bit weird to use the native path functions only to then manually replace slashes. What do you think about:
sys::path::Style guessed_style = Config->PDBSourcePath.startswith("/")
? sys::path::Style::posix
: sys::path::Style::windows;
after the first return and then pass that to all the sys::path function calls in this function instead?
Repository:
rLLD LLVM Linker
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57769/new/
https://reviews.llvm.org/D57769
More information about the llvm-commits
mailing list