[PATCH] D57769: [PDB] Remove dots and canonicalize slashes when using /PDBSOURCEPATH

Zachary Turner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 5 11:58:13 PST 2019


zturner added a comment.

In D57769#1385789 <https://reviews.llvm.org/D57769#1385789>, @thakis wrote:

>   // Only apply native and dot removal to the relative file path.  We want to
>   // leave the path the user specified untouched since we assume they specified
>   // it for a reason.
>   
>
> Is that necessary for anything? That doesn't look like the behavior we want -- we do want /pdbsourcepath:c:\foo\bar and a file with a relative path of ..\..\blah to become c:\blah. Can we undo that bit to fix (1)?


It's possible I'm misunderstanding your comment, but I actually did remove that in this patch?


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57769/new/

https://reviews.llvm.org/D57769





More information about the llvm-commits mailing list