[PATCH] D57679: [LLD] [MinGW] Hook up the --no-insert-timestamp option

[Rui Ueyama via llvm-commits]

For completeness, why don't you add both -insert-timestamp and
-no-insert-timestamp?

On Tue, Feb 5, 2019 at 12:16 AM Martin Storsjö via Phabricator <
reviews at reviews.llvm.org> wrote:

> This revision was automatically updated to reflect the committed changes.
> Closed by commit rL353145: [MinGW] Hook up the --no-insert-timestamp
> option (authored by mstorsjo, committed by ).
>
> Changed prior to commit:
>   https://reviews.llvm.org/D57679?vs=185026&id=185246#toc
>
> Repository:
>   rL LLVM
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D57679/new/
>
> https://reviews.llvm.org/D57679
>
> Files:
>   lld/trunk/MinGW/Driver.cpp
>   lld/trunk/MinGW/Options.td
>   lld/trunk/test/MinGW/driver.test
>
>
> Index: lld/trunk/MinGW/Driver.cpp
> ===================================================================
> --- lld/trunk/MinGW/Driver.cpp
> +++ lld/trunk/MinGW/Driver.cpp
> @@ -187,6 +187,9 @@
>        Args.getLastArgValue(OPT_m) != "arm64pe" &&
> !Args.hasArg(OPT_dynamicbase))
>      Add("-dynamicbase:no");
>
> +  if (Args.hasArg(OPT_no_insert_timestamp))
> +    Add("-timestamp:0");
> +
>    if (Args.hasFlag(OPT_gc_sections, OPT_no_gc_sections, false))
>      Add("-opt:ref");
>    else
> Index: lld/trunk/MinGW/Options.td
> ===================================================================
> --- lld/trunk/MinGW/Options.td
> +++ lld/trunk/MinGW/Options.td
> @@ -22,6 +22,8 @@
>  def m: JoinedOrSeparate<["-"], "m">, HelpText<"Set target emulation">;
>  def map: S<"Map">, HelpText<"Output a linker map">;
>  def map_eq: J<"Map=">, Alias<map>;
> +def no_insert_timestamp: F<"no-insert-timestamp">,
> +    HelpText<"Don't include PE header timestamp">;
>  def no_whole_archive: F<"no-whole-archive">,
>      HelpText<"No longer include all object files for following archives">;
>  def large_address_aware: Flag<["--"], "large-address-aware">,
> Index: lld/trunk/test/MinGW/driver.test
> ===================================================================
> --- lld/trunk/test/MinGW/driver.test
> +++ lld/trunk/test/MinGW/driver.test
> @@ -151,3 +151,6 @@
>
>  RUN: ld.lld -### -m i386pep foo.o -Llibpath | FileCheck -check-prefix
> LIBPATH %s
>  LIBPATH: -libpath:libpath
> +
> +RUN: ld.lld -### -m i386pep foo.o --no-insert-timestamp | FileCheck
> -check-prefix NOTIMESTAMP %s
> +NOTIMESTAMP: -timestamp:0
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190205/209b19dc/attachment.html>