<div dir="ltr">For completeness, why don't you add both -insert-timestamp and -no-insert-timestamp?</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Feb 5, 2019 at 12:16 AM Martin Storsjö via Phabricator <<a href="mailto:reviews@reviews.llvm.org">reviews@reviews.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">This revision was automatically updated to reflect the committed changes.<br>
Closed by commit rL353145: [MinGW] Hook up the --no-insert-timestamp option (authored by mstorsjo, committed by ).<br>
<br>
Changed prior to commit:<br>
  <a href="https://reviews.llvm.org/D57679?vs=185026&id=185246#toc" rel="noreferrer" target="_blank">https://reviews.llvm.org/D57679?vs=185026&id=185246#toc</a><br>
<br>
Repository:<br>
  rL LLVM<br>
<br>
CHANGES SINCE LAST ACTION<br>
  <a href="https://reviews.llvm.org/D57679/new/" rel="noreferrer" target="_blank">https://reviews.llvm.org/D57679/new/</a><br>
<br>
<a href="https://reviews.llvm.org/D57679" rel="noreferrer" target="_blank">https://reviews.llvm.org/D57679</a><br>
<br>
Files:<br>
  lld/trunk/MinGW/Driver.cpp<br>
  lld/trunk/MinGW/Options.td<br>
  lld/trunk/test/MinGW/driver.test<br>
<br>
<br>
Index: lld/trunk/MinGW/Driver.cpp<br>
===================================================================<br>
--- lld/trunk/MinGW/Driver.cpp<br>
+++ lld/trunk/MinGW/Driver.cpp<br>
@@ -187,6 +187,9 @@<br>
       Args.getLastArgValue(OPT_m) != "arm64pe" && !Args.hasArg(OPT_dynamicbase))<br>
     Add("-dynamicbase:no");<br>
<br>
+  if (Args.hasArg(OPT_no_insert_timestamp))<br>
+    Add("-timestamp:0");<br>
+<br>
   if (Args.hasFlag(OPT_gc_sections, OPT_no_gc_sections, false))<br>
     Add("-opt:ref");<br>
   else<br>
Index: lld/trunk/MinGW/Options.td<br>
===================================================================<br>
--- lld/trunk/MinGW/Options.td<br>
+++ lld/trunk/MinGW/Options.td<br>
@@ -22,6 +22,8 @@<br>
 def m: JoinedOrSeparate<["-"], "m">, HelpText<"Set target emulation">;<br>
 def map: S<"Map">, HelpText<"Output a linker map">;<br>
 def map_eq: J<"Map=">, Alias<map>;<br>
+def no_insert_timestamp: F<"no-insert-timestamp">,<br>
+    HelpText<"Don't include PE header timestamp">;<br>
 def no_whole_archive: F<"no-whole-archive">,<br>
     HelpText<"No longer include all object files for following archives">;<br>
 def large_address_aware: Flag<["--"], "large-address-aware">,<br>
Index: lld/trunk/test/MinGW/driver.test<br>
===================================================================<br>
--- lld/trunk/test/MinGW/driver.test<br>
+++ lld/trunk/test/MinGW/driver.test<br>
@@ -151,3 +151,6 @@<br>
<br>
 RUN: ld.lld -### -m i386pep foo.o -Llibpath | FileCheck -check-prefix LIBPATH %s<br>
 LIBPATH: -libpath:libpath<br>
+<br>
+RUN: ld.lld -### -m i386pep foo.o --no-insert-timestamp | FileCheck -check-prefix NOTIMESTAMP %s<br>
+NOTIMESTAMP: -timestamp:0<br>
<br>
<br>
</blockquote></div>