[PATCH] D57760: Fix defines.txt test failure on Windows targets

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

I'm about to leave the office for the day, but as long as you remove the portion of the check as suggested, I'm happy to give this an LGTM now.



================
Comment at: llvm/test/FileCheck/defines.txt:27
 
-; ERRCLIEQ2: FileCheck{{[^:]*}}: for the -D option: requires a value!
+; ERRCLIEQ2: [fF]ile[cC]heck{{[^:]*}}: for the -D option: requires a value!
 
----------------
thopre wrote:
> jhenderson wrote:
> > Maybe we just don't need to test that "FileCheck" appears in the error message at all? I'm not really convinced it belongs in the error message anyway, but that's a separate issue.
> I was wondering about that myself. So what about:
> 
> ; ERRCLIEQ2: for the -D option: requires a value!
Yes, exactly.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57760/new/

https://reviews.llvm.org/D57760