[PATCH] D57760: Fix defines.txt test failure on Windows targets

Thomas Preud'homme via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 5 09:38:38 PST 2019


thopre marked an inline comment as done.
thopre added inline comments.


================
Comment at: llvm/test/FileCheck/defines.txt:27
 
-; ERRCLIEQ2: FileCheck{{[^:]*}}: for the -D option: requires a value!
+; ERRCLIEQ2: [fF]ile[cC]heck{{[^:]*}}: for the -D option: requires a value!
 
----------------
jhenderson wrote:
> Maybe we just don't need to test that "FileCheck" appears in the error message at all? I'm not really convinced it belongs in the error message anyway, but that's a separate issue.
I was wondering about that myself. So what about:

; ERRCLIEQ2: for the -D option: requires a value!


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57760/new/

https://reviews.llvm.org/D57760





More information about the llvm-commits mailing list