[PATCH] D57620: Optimize printf calls that don't use 128-bit floating-point values

[Dan Gohman via Phabricator via llvm-commits]

sunfish planned changes to this revision.
sunfish marked 4 inline comments as done.
sunfish added inline comments.


================
Comment at: lib/Analysis/TargetLibraryInfo.cpp:157
+  if (T.getArch() != Triple::xcore && T.getArch() != Triple::tce &&
+      T.getOS() != Triple::WASI) {
     TLI.setUnavailable(LibFunc_iprintf);
----------------
sbc100 wrote:
> This part is a separate and can be split out?
Ok.


================
Comment at: lib/Transforms/Utils/SimplifyLibCalls.cpp:2035
+        M->getOrInsertFunction(TLI->getName(LibFunc_iprintf),
+                               FT, Callee->getAttributes());
     CallInst *New = cast<CallInst>(CI->clone());
----------------
sbc100 wrote:
> .. along with this?
Yes, this was a cleanup that isn't strictly required by the rest of the patch. I've now reverted these cleanups.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57620/new/

https://reviews.llvm.org/D57620