[PATCH] D57685: MIR: Validate LLT types when parsing

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 4 14:11:43 PST 2019


arsenm marked an inline comment as done.
arsenm added inline comments.


================
Comment at: lib/CodeGen/MIRParser/MIParser.cpp:1344
+static bool verifyScalarSize(uint64_t Size) {
+  return Size != 0 && isUInt<16>(Size);
+}
----------------
paquette wrote:
> Where are these values documented? Can we have a comment that points out where these are documented? I trust that the values are correct, but it'd be nice to know.
In LowLevelTypeImpl.h


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57685/new/

https://reviews.llvm.org/D57685





More information about the llvm-commits mailing list