[PATCH] D57685: MIR: Validate LLT types when parsing

[Jessica Paquette via Phabricator via llvm-commits]

paquette accepted this revision.
paquette added a comment.
This revision is now accepted and ready to land.

This seems like a pretty good idea... LGTM, aside from the one nit.



================
Comment at: lib/CodeGen/MIRParser/MIParser.cpp:1344
+static bool verifyScalarSize(uint64_t Size) {
+  return Size != 0 && isUInt<16>(Size);
+}
----------------
Where are these values documented? Can we have a comment that points out where these are documented? I trust that the values are correct, but it'd be nice to know.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57685/new/

https://reviews.llvm.org/D57685