[PATCH] D57612: gn build: Windows: write PDBs when is_debug
David Major via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Feb 4 13:13:34 PST 2019
This revision was automatically updated to reflect the committed changes.
Closed by commit rL353093: gn build: Windows: write PDBs when is_debug (authored by dmajor, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D57612?vs=184813&id=185143#toc
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57612/new/
https://reviews.llvm.org/D57612
Files:
llvm/trunk/utils/gn/build/BUILD.gn
Index: llvm/trunk/utils/gn/build/BUILD.gn
===================================================================
--- llvm/trunk/utils/gn/build/BUILD.gn
+++ llvm/trunk/utils/gn/build/BUILD.gn
@@ -34,7 +34,11 @@
]
} else {
if (is_debug) {
- cflags += [ "/Zi" ]
+ cflags += [
+ "/Zi",
+ "/FS",
+ ]
+ ldflags += [ "/DEBUG" ]
} else {
cflags += [
"/O2",
@@ -57,7 +61,7 @@
# The MSVC default value (1 MB) is not enough for parsing recursive C++
# templates in Clang.
- ldflags = [ "/STACK:10000000" ]
+ ldflags += [ "/STACK:10000000" ]
}
# Warning setup.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D57612.185143.patch
Type: text/x-patch
Size: 640 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190204/1f92e9e1/attachment.bin>
More information about the llvm-commits
mailing list