[llvm] r353093 - gn build: Windows: write PDBs when is_debug

[David Major via llvm-commits]

Author: dmajor
Date: Mon Feb  4 13:13:43 2019
New Revision: 353093

URL: http://llvm.org/viewvc/llvm-project?rev=353093&view=rev
Log:
gn build: Windows: write PDBs when is_debug

Without /DEBUG, the /Zi doesn't on its own create PDB files.

And since ninja runs multiple compilations in parallel, we need /FS to prevent contention on PDBs.

Differential Revision: https://reviews.llvm.org/D57612


Modified:
    llvm/trunk/utils/gn/build/BUILD.gn

Modified: llvm/trunk/utils/gn/build/BUILD.gn
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/gn/build/BUILD.gn?rev=353093&r1=353092&r2=353093&view=diff
==============================================================================
--- llvm/trunk/utils/gn/build/BUILD.gn (original)
+++ llvm/trunk/utils/gn/build/BUILD.gn Mon Feb  4 13:13:43 2019
@@ -34,7 +34,11 @@ config("compiler_defaults") {
     ]
   } else {
     if (is_debug) {
-      cflags += [ "/Zi" ]
+      cflags += [
+        "/Zi",
+        "/FS",
+      ]
+      ldflags += [ "/DEBUG" ]
     } else {
       cflags += [
         "/O2",
@@ -57,7 +61,7 @@ config("compiler_defaults") {
 
     # The MSVC default value (1 MB) is not enough for parsing recursive C++
     # templates in Clang.
-    ldflags = [ "/STACK:10000000" ]
+    ldflags += [ "/STACK:10000000" ]
   }
 
   # Warning setup.