[PATCH] D57703: [AMDGPU] Consider XOR in waterfall loop as a terminator

Mon Feb 4 12:53:04 PST 2019

arsenm added a comment.

In D57703#1383842 <https://reviews.llvm.org/D57703#1383842>, @scott.linder wrote:

> I agree the test does not test much at all, it was just the minimum I could think of considering none of our existing tests notice the change. I'm not sure what pass you mean by 'isel', but 'stop-after=amdgpu-isel' is too early to see the SI_INDIRECT_SRC_* psuedo expanded.
>
> You mentioned to try at -O0 and I see spill code being inserted between the xor and branch in the current trunk. I've updated the test to just go to ISA and confirm there is no intervening instruction between the xor and branch, but I don't know if this is what you had in mind either.

Oh, right. This needs to be after expand-isel-pseudos

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57703/new/

https://reviews.llvm.org/D57703