[PATCH] D57030: [CommandLine] Don't print empty sentinel values from EnumValN lists in help text
    James Henderson via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Mon Feb  4 03:26:21 PST 2019
    
    
  
jhenderson added a comment.
In D57030#1382899 <https://reviews.llvm.org/D57030#1382899>, @thopre wrote:
> Forgot some nits about the description (please ignore if it doesn't end up in the commit message):
>
> - remove the last sentence about testing since you've added unit testing
> - instead of describing a change I find that a small example like you did in your second quote block would be clearer
> - you mention --option=var but your example is of the form -option=var which is confusing
Yeah, I actually changed it quite a bit in the original commit, but I since realised that there were other improvements I could make, so I've updated the description to match my planned submission. Please let me know if you are happy with the latest round of updates (both code and description).
Repository:
  rL LLVM
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57030/new/
https://reviews.llvm.org/D57030
    
    
More information about the llvm-commits
mailing list