[PATCH] D57030: [CommandLine] Don't print empty sentinel values from EnumValN lists in help text

Thomas Preud'homme via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 4 03:11:36 PST 2019


thopre added a comment.

Forgot some nits about the description (please ignore if it doesn't end up in the commit message):

- remove the last sentence about testing since you've added unit testing
- instead of describing a change I find that a small example like you did in your second quote block would be clearer
- you mention --option=var but your example is of the form -option=var which is confusing


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57030/new/

https://reviews.llvm.org/D57030





More information about the llvm-commits mailing list