[PATCH] D57609: [DebugInfo] Don't use realpath when looking up debug binary locations.

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 1 12:10:18 PST 2019


dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

In the absence of further info about the original commit/intended functionality - sure. If it breaks, we'll at least know why it was this way in the first place. :)



================
Comment at: llvm/test/DebugInfo/symbolize-gnu-debuglink-no-realpath.test:5-6
+# Copy inputs to some other location with arbitrary names, with the original
+# filenames just being symlinks to the copies. Real files go in the "objs" dir,
+# symlinks (with original names) go in "runfiles".
+RUN: rm -rf %t/objs %t/runfiles
----------------
Perhaps name the directories "real" and "sym" so they're more self explanatory?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57609/new/

https://reviews.llvm.org/D57609





More information about the llvm-commits mailing list