[PATCH] D57602: [WebAssembly] Add an import_field function attribute
Sam Clegg via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Feb 1 11:39:07 PST 2019
sbc100 accepted this revision.
sbc100 added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: llvm-commits.
Do you could also achieve this I guess by renaming pwsix.read function itself to pwsix.__read? But I guess it makes sense to allow the use to control all 3 parts of the name separately.
BTW, I've never liked the word field here. I think "wasm-import-name" would make more sense, but that would conflict with the spec I suppose, and also this should be very rarely needed attr.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57602/new/
https://reviews.llvm.org/D57602
More information about the llvm-commits
mailing list