[PATCH] D57030: [CommandLine] Don't print empty sentinel values from EnumValN lists in help text

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 1 06:57:43 PST 2019


jhenderson updated this revision to Diff 184741.
jhenderson added a comment.

Fix `getOptionWidth` function for new behaviour, add some asserts for protection, add new unit tests for `getOptionWidth`, and pull out some of the brittle constants and strings into a single set of static variables.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57030/new/

https://reviews.llvm.org/D57030

Files:
  lib/Support/CommandLine.cpp
  tools/llvm-symbolizer/llvm-symbolizer.cpp
  unittests/Support/CommandLineTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D57030.184741.patch
Type: text/x-patch
Size: 14533 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190201/831975a9/attachment.bin>


More information about the llvm-commits mailing list