[PATCH] D57030: [CommandLine] Don't print empty sentinel values from EnumValN lists in help text

Fri Feb 1 03:10:24 PST 2019

mstorsjo added a comment.

In D57030#1380373 <https://reviews.llvm.org/D57030#1380373>, @jhenderson wrote:

> I've been able to reproduce the failure by extending the length of the switch by a large amount. I think, though not yet confirmed, that the problem is that this patch didn't adjust the apparent option width due to adding "=<value>". You may be seeing it because you are building without the Hexagon target? That causes the `-aarch64-neon-syntax=<value>` line to be the longest arg string, and greater than the GlobalWidth, I believe, causing an underflow somewhere in the adjusted code.

Yes, that's correct, I'm building with ARM+AArch64+X86 only (and could also reproduce it in a build with AArch64 only).

> I'll look at fixing that.

Great, thanks!

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57030/new/

https://reviews.llvm.org/D57030