[PATCH] D57543: [llvm-objcopy][NFC] Propagate errors in removeSymbols/removeSectionReferences
Jordan Rupprecht via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Feb 1 06:52:35 PST 2019
rupprecht marked 2 inline comments as done.
rupprecht added inline comments.
================
Comment at: llvm/tools/llvm-objcopy/ELF/ELFObjcopy.cpp:188-189
auto DWOFile = Reader.create();
- DWOFile->removeSections(
- [&](const SectionBase &Sec) { return onlyKeepDWOPred(*DWOFile, Sec); });
+ auto OnlyKeepDWOPred = [&DWOFile](const SectionBase &Sec) {
+ return onlyKeepDWOPred(*DWOFile, Sec);
+ };
----------------
jhenderson wrote:
> Is moving this out-of-line just a readability thing (it's fine if so)? Otherwise I'm missing why you're doing it (ditto below).
Yes, just seemed more readable this way.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57543/new/
https://reviews.llvm.org/D57543
More information about the llvm-commits
mailing list