[PATCH] D57543: [llvm-objcopy][NFC] Propagate errors in removeSymbols/removeSectionReferences

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.
Herald added a project: LLVM.

LGTM.



================
Comment at: llvm/tools/llvm-objcopy/ELF/ELFObjcopy.cpp:188-189
   auto DWOFile = Reader.create();
-  DWOFile->removeSections(
-      [&](const SectionBase &Sec) { return onlyKeepDWOPred(*DWOFile, Sec); });
+  auto OnlyKeepDWOPred = [&DWOFile](const SectionBase &Sec) {
+    return onlyKeepDWOPred(*DWOFile, Sec);
+  };
----------------
Is moving this out-of-line just a readability thing (it's fine if so)? Otherwise I'm missing why you're doing it (ditto below).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57543/new/

https://reviews.llvm.org/D57543