[PATCH] D56948: [AArch64] Include AArch64GenCallingConv.inc once

[Reid Kleckner via Phabricator via llvm-commits]

rnk marked an inline comment as done.
rnk added inline comments.


================
Comment at: llvm/trunk/lib/Target/AArch64/AArch64CallingConvention.h:1
-//=== AArch64CallingConv.h - Custom Calling Convention Routines -*- C++ -*-===//
+//=== AArch64CallingConvention.h - AArch64 CC entry points ------*- C++ -*-===//
 //
----------------
pcc wrote:
> Should this file be tblgen'erated?
It could be. X86 has so few entry points, I was surprised by the way that ARM/AArch64 did things, so I didn't plan this up front. However, there's not that much incremental value to changing the way this all works, so I don't think it will make the top of my priority list.

One way to make this code less repetitive would be to use a typedef for the CC entry point function prototype and declare these like variables. Less repetitive, but also unclear. =/
  typedef bool CCEntryFTy(unsigned, ...);
  CCEntryFTy CC_AArch64_AAPCS;
  ...


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56948/new/

https://reviews.llvm.org/D56948