[PATCH] D57038: GlobalISel: Partially implement widenScalar for MERGE_VALUES

Amara Emerson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 28 13:25:59 PST 2019


aemerson accepted this revision.
aemerson added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: Petar.Avramovic.

LGTM.



================
Comment at: test/CodeGen/AArch64/GlobalISel/legalize-merge-values.mir:4
 
---- |
-  target datalayout = "e-m:o-i64:64-i128:128-n32:64-S128"
-  target triple = "aarch64--"
-  define void @test_merge_s4() {
-    ret void
-  }
-...
+# Previously, LegalizerInfo was assuming all G_MERGE_VALUES and G_UNMERGE_VALUES
+# instructions are legal. Make sure that is no longer happening.
----------------
This comment can now be removed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57038/new/

https://reviews.llvm.org/D57038





More information about the llvm-commits mailing list