[PATCH] D57533: lit: support long paths on Windows

[Zachary Turner via llvm-commits]

How about putting this in lit.util and make a function called
remove_directory() then call this function (here and throughput the rest of
lit)
On Thu, Jan 31, 2019 at 12:22 PM Shoaib Meenai via Phabricator <
reviews at reviews.llvm.org> wrote:

> smeenai added inline comments.
>
>
> ================
> Comment at: utils/lit/lit/TestRunner.py:619
> +                    path = os.path.abspath(path)
> +                    if not
> ctypes.windll.kernel32.RemoveDirectoryW(r'\\?\%s' % path):
> +                        raise ctypes.WinError()
> ----------------
> Shouldn't the error handling logic match the other branch (`on_rm_error if
> force else None`)?
>
>
> Repository:
>   rL LLVM
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D57533/new/
>
> https://reviews.llvm.org/D57533
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190131/0b137ecc/attachment.html>