[PATCH] D57533: lit: support long paths on Windows

Shoaib Meenai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 31 12:21:59 PST 2019


smeenai added inline comments.


================
Comment at: utils/lit/lit/TestRunner.py:619
+                    path = os.path.abspath(path)
+                    if not ctypes.windll.kernel32.RemoveDirectoryW(r'\\?\%s' % path):
+                        raise ctypes.WinError()
----------------
Shouldn't the error handling logic match the other branch (`on_rm_error if force else None`)?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57533/new/

https://reviews.llvm.org/D57533





More information about the llvm-commits mailing list