[PATCH] D57406: build: remove use of llvm-config

[Tom Stellard via Phabricator via llvm-commits]

tstellar added a comment.

In D57406#1377725 <https://reviews.llvm.org/D57406#1377725>, @xiaobai wrote:

> I wrote a patch similar to this in LLDB, so I'll chime in a bit.
>
> @mgorny: This doesn't actually *break* the build per se. This change just means you need to do a bit more work to be able to test the lld you just built. Some things that could be done to improve the situation:
>
> - Users who want to test lld should specify `LLVM_BUILD_MAIN_SRC_DIR` (and possibly `LLVM_LIT_EXE`) manually.


This isn't actually different from what you had to do before this patch.  The only difference is that LLVM_MAIN_SRC_DIR was a CACHE variable, but now LLVM_BUILD_MAIN_SRC_DIR is not.
The request was to have a CACHE variable

> - Introduce some new variable like `PATH_TO_LLVM_SRC` and replace `LLVM_BUILD_MAIN_SRC_DIR`. This could be optional variable which would need to be set if you want to test.
> 
>   I don't see this as a hard blocker for putting this patch in. It simplifies the build logic because we don't have to call out to some other process and parse its output, and it de-duplicates work because the LLVM CMake package provides a lot of the variables that we were filling out.

The issue here is that the old variable LLVM_MAIN_SRC_DIR was a CACHE variable and LLVM_


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57406/new/

https://reviews.llvm.org/D57406