[PATCH] D57406: build: remove use of llvm-config

[Alex Langford via Phabricator via llvm-commits]

xiaobai added a comment.

I wrote a patch similar to this in LLDB, so I'll chime in a bit.

@mgorny: This doesn't actually *break* the build per se. This change just means you need to do a bit more work to be able to test the lld you just built. Some things that could be done to improve the situation:

- Users who want to test lld should specify `LLVM_BUILD_MAIN_SRC_DIR` (and possibly `LLVM_LIT_EXE`) manually.
- Introduce some new variable like `PATH_TO_LLVM_SRC` and replace `LLVM_BUILD_MAIN_SRC_DIR`. This could be optional variable which would need to be set if you want to test.

I don't see this as a hard blocker for putting this patch in. It simplifies the build logic because we don't have to call out to some other process and parse its output, and it de-duplicates work because the LLVM CMake package provides a lot of the variables that we were filling out.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57406/new/

https://reviews.llvm.org/D57406