[PATCH] D57423: [llvm-objcopy][NFC] More error propagation

[Jake Ehrlich via llvm-commits]

Yeah I knew it wasn't everything but this is progress.

On Wed, Jan 30, 2019, 6:46 AM Jordan Rupprecht via Phabricator <
reviews at reviews.llvm.org> wrote:

> rupprecht added a comment.
>
> In D57423#1376475 <https://reviews.llvm.org/D57423#1376475>,
> @jakehehrlich wrote:
>
> > OMG thank you. I've been wanting this to happen so badly. LGTM.
>
>
> :)
> There's about 40 calls to error/reportError from outside the main driver
> class, this fixes 10-ish of them, so still over half of them to go...
>
>
>
> ================
> Comment at: llvm/tools/llvm-objcopy/llvm-objcopy.cpp:147-148
>
> -static void executeObjcopyOnArchive(const CopyConfig &Config,
> -                                    const Archive &Ar) {
> +static Error executeObjcopyOnArchive(const CopyConfig &Config,
> +                                     const Archive &Ar) {
>    std::vector<NewArchiveMember> NewArchiveMembers;
> ----------------
> jhenderson wrote:
> > You seem to have missed several `reportError` calls in this function.
> Was that intentional?
> Nope -- missed this one, I'll follow up with a fix. (Accidentally checked
> in this one instead of D57248 before addressing this, sorry... was in the
> wrong git branch :( ).
>
>
> Repository:
>   rL LLVM
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D57423/new/
>
> https://reviews.llvm.org/D57423
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190130/d7fb548a/attachment.html>