Yeah I knew it wasn't everything but this is progress.<br><br><div class="gmail_quote"><div dir="ltr">On Wed, Jan 30, 2019, 6:46 AM Jordan Rupprecht via Phabricator <<a href="mailto:reviews@reviews.llvm.org">reviews@reviews.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">rupprecht added a comment.<br>
<br>
In D57423#1376475 <<a href="https://reviews.llvm.org/D57423#1376475" rel="noreferrer" target="_blank">https://reviews.llvm.org/D57423#1376475</a>>, @jakehehrlich wrote:<br>
<br>
> OMG thank you. I've been wanting this to happen so badly. LGTM.<br>
<br>
<br>
:)<br>
There's about 40 calls to error/reportError from outside the main driver class, this fixes 10-ish of them, so still over half of them to go...<br>
<br>
<br>
<br>
================<br>
Comment at: llvm/tools/llvm-objcopy/llvm-objcopy.cpp:147-148<br>
<br>
-static void executeObjcopyOnArchive(const CopyConfig &Config,<br>
-                                    const Archive &Ar) {<br>
+static Error executeObjcopyOnArchive(const CopyConfig &Config,<br>
+                                     const Archive &Ar) {<br>
   std::vector<NewArchiveMember> NewArchiveMembers;<br>
----------------<br>
jhenderson wrote:<br>
> You seem to have missed several `reportError` calls in this function. Was that intentional?<br>
Nope -- missed this one, I'll follow up with a fix. (Accidentally checked in this one instead of D57248 before addressing this, sorry... was in the wrong git branch :( ).<br>
<br>
<br>
Repository:<br>
  rL LLVM<br>
<br>
CHANGES SINCE LAST ACTION<br>
  <a href="https://reviews.llvm.org/D57423/new/" rel="noreferrer" target="_blank">https://reviews.llvm.org/D57423/new/</a><br>
<br>
<a href="https://reviews.llvm.org/D57423" rel="noreferrer" target="_blank">https://reviews.llvm.org/D57423</a><br>
<br>
<br>
<br>
</blockquote></div>