[PATCH] D57182: [MC] Remove unused inline function and stale comments; NFC

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast updated this revision to Diff 184171.
hubert.reinterpretcast added a comment.

Address comments: Let public defaulted destructors be implicitly defined


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57182/new/

https://reviews.llvm.org/D57182

Files:
  include/llvm/MC/MCSectionCOFF.h
  include/llvm/MC/MCSectionELF.h
  include/llvm/MC/MCSectionWasm.h
  lib/MC/MCSectionCOFF.cpp
  lib/MC/MCSectionELF.cpp
  lib/MC/MCSectionWasm.cpp


Index: lib/MC/MCSectionWasm.cpp
===================================================================
--- lib/MC/MCSectionWasm.cpp
+++ lib/MC/MCSectionWasm.cpp
@@ -14,8 +14,6 @@
 
 using namespace llvm;
 
-MCSectionWasm::~MCSectionWasm() {} // anchor.
-
 // Decides whether a '.section' directive
 // should be printed before the section name.
 bool MCSectionWasm::ShouldOmitSectionDirective(StringRef Name,
Index: lib/MC/MCSectionELF.cpp
===================================================================
--- lib/MC/MCSectionELF.cpp
+++ lib/MC/MCSectionELF.cpp
@@ -17,8 +17,6 @@
 
 using namespace llvm;
 
-MCSectionELF::~MCSectionELF() = default; // anchor.
-
 // Decides whether a '.section' directive
 // should be printed before the section name.
 bool MCSectionELF::ShouldOmitSectionDirective(StringRef Name,
Index: lib/MC/MCSectionCOFF.cpp
===================================================================
--- lib/MC/MCSectionCOFF.cpp
+++ lib/MC/MCSectionCOFF.cpp
@@ -14,8 +14,6 @@
 
 using namespace llvm;
 
-MCSectionCOFF::~MCSectionCOFF() = default; // anchor.
-
 // ShouldOmitSectionDirective - Decides whether a '.section' directive
 // should be printed before the section name
 bool MCSectionCOFF::ShouldOmitSectionDirective(StringRef Name,
Index: include/llvm/MC/MCSectionWasm.h
===================================================================
--- include/llvm/MC/MCSectionWasm.h
+++ include/llvm/MC/MCSectionWasm.h
@@ -48,11 +48,7 @@
       : MCSection(SV_Wasm, K, Begin), SectionName(Section), UniqueID(UniqueID),
         Group(group) {}
 
-  void setSectionName(StringRef Name) { SectionName = Name; }
-
 public:
-  ~MCSectionWasm();
-
   /// Decides whether a '.section' directive should be printed before the
   /// section name
   bool ShouldOmitSectionDirective(StringRef Name, const MCAsmInfo &MAI) const;
Index: include/llvm/MC/MCSectionELF.h
===================================================================
--- include/llvm/MC/MCSectionELF.h
+++ include/llvm/MC/MCSectionELF.h
@@ -63,8 +63,6 @@
   void setSectionName(StringRef Name) { SectionName = Name; }
 
 public:
-  ~MCSectionELF();
-
   /// Decides whether a '.section' directive should be printed before the
   /// section name
   bool ShouldOmitSectionDirective(StringRef Name, const MCAsmInfo &MAI) const;
Index: include/llvm/MC/MCSectionCOFF.h
===================================================================
--- include/llvm/MC/MCSectionCOFF.h
+++ include/llvm/MC/MCSectionCOFF.h
@@ -62,8 +62,6 @@
   }
 
 public:
-  ~MCSectionCOFF();
-
   /// Decides whether a '.section' directive should be printed before the
   /// section name
   bool ShouldOmitSectionDirective(StringRef Name, const MCAsmInfo &MAI) const;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D57182.184171.patch
Type: text/x-patch
Size: 2710 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190129/7cb98379/attachment.bin>