[PATCH] D57182: [MC] Remove unused inline function and stale comments; NFC

Hubert Tong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 28 16:40:34 PST 2019


hubert.reinterpretcast marked an inline comment as done.
hubert.reinterpretcast added inline comments.


================
Comment at: lib/MC/MCSectionCOFF.cpp:17
 
-MCSectionCOFF::~MCSectionCOFF() = default; // anchor.
 
----------------
sbc100 wrote:
> If its not longer an anchor then presumably it can be removed from the .cpp file?    And in fact since its empty removed from the .h file too?
> 
> Ditto for ELF and wasm files.
Yes, I think I will do that. It does not look like these destructors do much other than calling the base destructor, and the base destructor is already out-of-line.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57182/new/

https://reviews.llvm.org/D57182





More information about the llvm-commits mailing list