[PATCH] D57370: [WebAssembly] Don't load weak undefined symbols from archive files

[Rui Ueyama via Phabricator via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: wasm/Driver.cpp:314
+
+    if (!Sig)
       continue;
----------------
sbc100 wrote:
> ruiu wrote:
> > Is this the same as `isa<FunctionSYmbol>(Sym) || isa<LazySymbol>(Sym)`? Looks like `Sig` can be nullptr if Lazy, but I don't understand what's that case.
> Yes, the LazySymbol might not be function at all.  It might be a data symbol in which case it won't have a signature.
Ah, got it. I'd add a brief comment saying that if Sig is null, that means Sym was not a function.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57370/new/

https://reviews.llvm.org/D57370