[PATCH] D57370: [WebAssembly] Don't load weak undefined symbols from archive files
Sam Clegg via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jan 29 12:28:15 PST 2019
sbc100 added inline comments.
================
Comment at: wasm/Driver.cpp:314
+
+ if (!Sig)
continue;
----------------
ruiu wrote:
> Is this the same as `isa<FunctionSYmbol>(Sym) || isa<LazySymbol>(Sym)`? Looks like `Sig` can be nullptr if Lazy, but I don't understand what's that case.
Yes, the LazySymbol might not be function at all. It might be a data symbol in which case it won't have a signature.
Repository:
rLLD LLVM Linker
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57370/new/
https://reviews.llvm.org/D57370
More information about the llvm-commits
mailing list