[PATCH] D57350: [llvm-cxxfilt] Split input and demangle each word.

Matt Davis via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 29 09:35:03 PST 2019


mattd marked 2 inline comments as done.
mattd added inline comments.


================
Comment at: llvm/tools/llvm-cxxfilt/llvm-cxxfilt.cpp:9-11
+#include "llvm/ADT/SmallVector.h"
+#include "llvm/ADT/StringExtras.h"
+#include "llvm/ADT/StringRef.h"
----------------
jhenderson wrote:
> I'm not sure you need (some of) these headers, even if you use them, by my understanding of the coding guidelines, because e.g. CommandLine.h includes them: https://llvm.org/docs/CodingStandards.html#include-as-little-as-possible
I can indirectly include SmallVector and StringRef.  I'll still need to include StringExtras.  


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57350/new/

https://reviews.llvm.org/D57350





More information about the llvm-commits mailing list