[PATCH] D57350: [llvm-cxxfilt] Split input and demangle each word.
Matt Davis via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jan 29 09:07:30 PST 2019
mattd marked an inline comment as done.
mattd added a comment.
In D57350#1375540 <https://reviews.llvm.org/D57350#1375540>, @compnerd wrote:
> This actually breaks the compatibility with the existing tools. The quoted string is supposed to be interpreted as a *single* entry. I think that if you want to support something like this, it should be a separate flag for this behaviour.
That's a fair point. I'll respin the patch with a flag. Thanks for taking a look.
================
Comment at: llvm/test/tools/llvm-cxxfilt/types.test:2
RUN: llvm-cxxfilt -t f i | FileCheck %s
+RUN: llvm-cxxfilt -t "f i" | FileCheck %s --check-prefix="CHECK-STRING"
----------------
jhenderson wrote:
> You probably don't need this test, as it doesn't test any different functionality than the first test.
You are correct, this test is similar to the earlier test, but I wanted to the added functionality against the '-t' option as well.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57350/new/
https://reviews.llvm.org/D57350
More information about the llvm-commits
mailing list