[PATCH] D57323: [WebAssembly] Enable main-function signature rewriting for WASI

[Sam Clegg via Phabricator via llvm-commits]

sbc100 added a comment.

In D57323#1374661 <https://reviews.llvm.org/D57323#1374661>, @sunfish wrote:

> In D57323#1374572 <https://reviews.llvm.org/D57323#1374572>, @sbc100 wrote:
>
> > I mean with your fix we don't need this to be wasi specific do we?
>
>
> It needs to align with what crt1.o does though, which is specific to the OS. For WASI's crt1.o, my current working theory is to just support the two standard-required cases and not the `envp` case. But for the `unknown` OS, we don't know what people might want to link to.


But we already decided we wanted this behaviour and my change only got reverted because it was demoting the 3-arg form to the 2-arg form.    Musl's crt0 currently expects the 2-arg form so this would align exactly with what you have done here:  promote the 0-arg to 2-arg form but leave the 3-arg form (and all other forms) alone.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57323/new/

https://reviews.llvm.org/D57323